Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clearCacheForPage on iOS #7

Merged
merged 3 commits into from Oct 21, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Oct 17, 2019

Details

This PR implements clearCacheForPage for iOS. On Android, we implemented it in #5.

JavaScript Usage:

PSPDFKit.clearCacheForPage(0, function() {
  alert("Cache cleared.");
});

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json and plugin.xml(see example commit: 09d5c6b).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/PSPDFKit-Cordova/releases).
  • Locally, pull the latest master and publish (npm publish) the new release to npm.

@radazzouz radazzouz added enhancement New feature or request ios labels Oct 17, 2019
@radazzouz radazzouz self-assigned this Oct 17, 2019
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/ios/PSPDFKitPlugin.m Show resolved Hide resolved
Because reloading the page already clears the cache.
@radazzouz radazzouz merged commit f7174e6 into master Oct 21, 2019
@radazzouz radazzouz deleted the rad/implement-clearCacheForPage-ios branch October 21, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants