Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autosaveEnabled configuration #289

Merged
merged 4 commits into from Sep 9, 2019
Merged

Add autosaveEnabled configuration #289

merged 4 commits into from Sep 9, 2019

Conversation

irgendeinich
Copy link
Contributor

@irgendeinich irgendeinich commented Sep 2, 2019 •
edited

Resolves #282

Details

  • This adds a new configuration option autosaveEnabled to match what iOS provides.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@irgendeinich irgendeinich self-assigned this Sep 2, 2019
@radazzouz
Copy link
Contributor

On iOS autosave is enabled by default and it can be disabled via disableAutomaticSaving . See https://github.com/PSPDFKit/react-native/blob/master/samples/Catalog/Catalog.ios.js#L461.

I think we should keep the naming consistent.

@irgendeinich irgendeinich merged commit 0389196 into master Sep 9, 2019
@irgendeinich irgendeinich deleted the reinhard/autosave-configuration branch September 9, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomassurin tomassurin tomassurin approved these changes

Assignees

@irgendeinich irgendeinich

Labels
Android enhancement READY TO REVIEW
Projects
None yet
Milestone
No milestone
3 participants
@irgendeinich @radazzouz @tomassurin