Add no_std compatibility #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, also, now you can really claim to be dependency-free :) |
|
Thanks, looks good! I'll have a look at the 32bit issues, maybe I can add 32bit tests to the CI. The spec doesn't cover the implementation, it just defines the format. |
|
published with 0.7.0 including 32-bit support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also noticed that it doesn't compile on 32-bit targets; I think some of the stuff like read_usize_ptr assume too much about the target platform. I think probably some of the uses of
usizeshould be changed to u64, which is always 8 bytes, although I'm not sure what the lz4 spec says. I tested using: