use stats #31
Closed
use stats #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements to doc linking, grammar, etc.
Update the docs to reflect the lack of LockParams, correct an error, and improve cross-linking.
unused and at the wrong placed
remove fast_field_cardinality from FastValue
add benchmarks for multivalued fastfield merge
* add support for deleting all documents matching query #1494
This started showing up with clippy in rust 1.64.
Use u8::from(bool), u64::from(bool).
fixes multivalue ff regression by avoiding using `get_val`. Line::train calls repeatedly get_val, but get_val implementation on Column for multivalues is very slow. The fix is to use the iterator instead. Longterm fix should be to remove get_val access in serialization. Old Code test fastfield::bench::bench_multi_value_ff_merge_few_segments ... bench: 46,103,960 ns/iter (+/- 2,066,083) test fastfield::bench::bench_multi_value_ff_merge_many_segments ... bench: 83,073,036 ns/iter (+/- 4,373,615) est fastfield::bench::bench_multi_value_ff_merge_many_segments_log_merge ... bench: 64,178,576 ns/iter (+/- 1,466,700) Current running 3 tests test fastfield::multivalued::bench::bench_multi_value_ff_merge_few_segments ... bench: 57,379,523 ns/iter (+/- 3,220,787) test fastfield::multivalued::bench::bench_multi_value_ff_merge_many_segments ... bench: 90,831,688 ns/iter (+/- 1,445,486) test fastfield::multivalued::bench::bench_multi_value_ff_merge_many_segments_log_merge ... bench: 158,313,264 ns/iter (+/- 28,823,250) With Fix running 3 tests test fastfield::multivalued::bench::bench_multi_value_ff_merge_few_segments ... bench: 57,635,671 ns/iter (+/- 2,707,361) test fastfield::multivalued::bench::bench_multi_value_ff_merge_many_segments ... bench: 91,468,712 ns/iter (+/- 11,393,581) test fastfield::multivalued::bench::bench_multi_value_ff_merge_many_segments_log_merge ... bench: 73,909,138 ns/iter (+/- 15,846,097)
clippy: Remove borrows that the compiler will do.
* Checking cfg_attr is no longer necessary. * Don't need multiple `clippy::` prefixes on a name.
* use binary search instead of linear for get_val in merge * use partition_point
prepare for ip field
This was removed in 2018, so these should be fine to remove now.
This is only used within the file watcher and is const, so it can't be configured.
This reads better this way.
When building without default features (so without mmap, etc), there are some warnings about unused things. This fixes the ones related to `ArcBytes` and `WeakArcBytes`, which are only used with the `mmap_directory` code.
Updates the requirements on [tantivy-fst](https://github.com/tantivy-search/fst) to permit the latest version. - [Release notes](https://github.com/tantivy-search/fst/releases) - [Commits](https://github.com/tantivy-search/fst/commits) --- updated-dependencies: - dependency-name: tantivy-fst dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…st-0.4.0 Update tantivy-fst requirement from 0.3.0 to 0.4.0
* Supporting PartialCmp in VectorColumn. * Apply suggestions from code review Co-authored-by: PSeitz <PSeitz@users.noreply.github.com>
* doc: update comments in the faceted search example * chore: format
…1750) * Make nightly Clippy mostly happy. * Document how to produce TermSetQuery queries using QueryParser. * Enable construction of queries using FuzzyTermQuery via the QueryParser * Use FxHashMap instead of HashMap in the QueryParser as these hash tables are not exposed to DoS attacks. * Use a struct instead of a tuple to improve readability.
Introduce MakeZero trait, remove make_zero from FastValue Merge two multivalue fastfield implementations into one prepare range query on fastfield for different types
…instances lazy. (#1756)
* Added support for dynamic fast field. See README for more information. * Apply suggestions from code review Co-authored-by: PSeitz <PSeitz@users.noreply.github.com>
closes #1766 Finding tantivy tokenizers is a frustrating experience currently, since they need be updated for each tantivy version. That's unnecessary since the API is rather stable anyway.
* enable range query on fast field for u64 compatible types * rename, update benches
Updates the requirements on [base64](https://github.com/marshallpierce/rust-base64) to permit the latest version. - [Release notes](https://github.com/marshallpierce/rust-base64/releases) - [Changelog](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md) - [Commits](marshallpierce/rust-base64@v0.20.0...v0.21.0) --- updated-dependencies: - dependency-name: base64 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This adds a regex tokenizer which tokenizes the text by using a regex pattern to split. Co-authored-by: Michael Kleen <mkleen@gmailw.com>
…-not-indexed-fields Allow range queries via fast fields on non-indexed fields
* handle user input on get_docid_for_value_range fixes #1757 * pass range as parameter
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 94.05% 94.12% +0.06%
==========================================
Files 230 282 +52
Lines 39350 53079 +13729
==========================================
+ Hits 37012 49960 +12948
- Misses 2338 3119 +781
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chronowithtime(Replacechronowithtimequickwit-oss/tantivy#1307)FruitHandleandMultiFruitpublic (MakeFruitHandleandMultiFruitpublic quickwit-oss/tantivy#1360)occurrencevar names and references (Fix variousoccurrencevar names and references quickwit-oss/tantivy#1385)src/collectorreadability (chore(collector):src/collectorreadability quickwit-oss/tantivy#1399)DisjunctionMaxQueryand refactorScoreCombinerseekmethod to RequiredOptionalScorer quickwit-oss/tantivy#1442)ConstScoreQuery(ConstScoreQueryquickwit-oss/tantivy#1463)OwnedBytesdoc clarification (OwnedBytesdoc clarification quickwit-oss/tantivy#1498)Write, add documentationColumn: Send + Syncquickwit-oss/tantivy#1518)/cppdirectory. (Remove references to/cppdirectory. quickwit-oss/tantivy#1560)Searcherpool. (doc: Remove reference toSearcherpool. quickwit-oss/tantivy#1598)Query::Weightto not need a Searcher when scoring is disabled. quickwit-oss/tantivy#1667)expand_dotsJsonObjectOptions. (Added aexpand_dotsJsonObjectOptions. quickwit-oss/tantivy#1687)split_full_pathtoSchema(Movesplit_full_pathtoSchemaquickwit-oss/tantivy#1692)