Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joss-review] Feedback on paper #25

Closed
9 tasks done
zonca opened this issue Apr 24, 2024 · 4 comments
Closed
9 tasks done

[joss-review] Feedback on paper #25

zonca opened this issue Apr 24, 2024 · 4 comments

Comments

@zonca
Copy link

zonca commented Apr 24, 2024 •
edited
Loading

Statement of need

  • Please explain where the 21-cm emission comes from
  • Gyr is too technical for the statement of need

Summary

Just a bit more details on the process

  • it would be useful to specify what parameters of an instrument you can characterize
  • also specify what is the format of the input data, are those timelines of some sort?
  • do you generally run this full-sky or works in patches?
  • do you use any other inputs besides instrument parameters and instrument data?

Figure 1

Explain terminology

  • phi
  • k
  • $\Delta K$
@zonca
Copy link
Author

zonca commented Apr 24, 2024

also "Do the authors describe how this software compares to other commonly-used packages?", aren't there other codes doing something similar?

@zonca zonca mentioned this issue Apr 24, 2024
Open
jburba added a commit that referenced this issue May 7, 2024
@jburba
First push of paper updates to address #25
f187521 
- Added a sentence where the 21-cm emission comes from
- Replaced "Gyr" with billion years
- Added a paragraph to the summery specifying the components of the instrument model, the form of the input data (with an added citation to pyuvdata), and some examples of analysis parameters
- Updated the figure caption to define the symbols in the subplot labels (\Delta^2(k), k, and \varphi)
jburba added a commit that referenced this issue May 7, 2024
@jburba
Add more information about running BayesEoR for #25
2e74011
jburba added a commit that referenced this issue May 7, 2024
@jburba
Remove hyphens in field-of-view #25
9dacb2e
jburba added a commit that referenced this issue May 10, 2024
@jburba
Reword intro to statement of need #25
07f9d8b
jburba added a commit that referenced this issue May 10, 2024
@jburba
Fix long sentence #25
fb35e15
jburba added a commit that referenced this issue May 10, 2024
@jburba
Remove extra s #25
63a3036
@jburba jburba mentioned this issue May 10, 2024
Merged
@jburba
Copy link
Collaborator

jburba commented May 10, 2024 •
edited
Loading

Hi @zonca , I think I've addressed your suggestions. Please give the most recent version of the paper a read and let me know what you think. I've also updated the documentation to include some more information about the inputs and more detail on running the analysis.

@zonca
Copy link
Author

zonca commented May 10, 2024

text is good, can you explain the terminology in the figure? best would be to add a caption.

@jburba
Copy link
Collaborator

jburba commented May 13, 2024

The figure caption only seems to appear in the pdf, not the markdown file. I'm not sure why that is.

@zonca zonca closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zonca @jburba