Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joss-review] Feedback on draft #30

Closed
8 tasks done
musoke opened this issue May 31, 2024 · 2 comments
Closed
8 tasks done

[joss-review] Feedback on draft #30

musoke opened this issue May 31, 2024 · 2 comments

Comments

@musoke
Copy link

musoke commented May 31, 2024

openjournals/joss-reviews#6667

The paper is much improved since the initial submission 馃槃

These comments are in reference to the latest draft (paper.pdf).

Writing

  • The balance between summary and statement of need seems off.
    The JOSS docs ask for "A summary describing the high-level functionality and purpose of the software for a diverse, non-specialist audience." I was expecting the summary to be similar to an abstract: first and shorter.

  • I would suggest adding sentences similar to the current lines 16-20 (about HERA/LOFAR/MWA and what they hope to learn) and 31-32 (your approach) to the start. Only explain details of 21cm after convincing the reader that it is interesting.

  • Figure: Say explicitly that inferred parameters on the left are the same coefficients as on the right.

  • Explain the quantities in the figure. Is this a power spectrum of 21-cm signal? Or hydrogen density?

  • Give an equation for $\Delta^2(k) = \sum ...$ as well as the current textual descritption.

State of the field

  • You briefly explain why this is a difficult task and describe your statistical techniques and implementation. I would like to see some mention of other approaches and how BayesEoR differs.
  • Is there alternative software that can be cited? Perhaps from the HERA, LoFAR, or MWA collaborations.

References

  • Should MultiNest be cited? It seems central to the analysis technique.
@jburba
Copy link
Collaborator

jburba commented Jun 11, 2024

Hi @musoke , thanks for your suggestions. I think I've implemented them all in the latest draft. Please see the latest PDF and let me know what you think. We decided to cite a couple of existing papers using our code which provide more details on comparisons of our approach with existing approaches. The details required to compare the approaches felt a bit too technical for this paper.

@musoke
Copy link
Author

musoke commented Jun 25, 2024

This looks good!

@musoke musoke closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants