Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Colored noise in FIRuncFilter and provide utility functions #55

Merged
merged 49 commits into from
Mar 20, 2020
Merged

Colored noise in FIRuncFilter and provide utility functions #55

merged 49 commits into from
Mar 20, 2020

Conversation

mgrub
Copy link
Contributor

@mgrub mgrub commented Jul 8, 2019 •
edited
Loading

Requires detailled review of implemented new methods

  • check normalization of created ideal autocorrelation
  • check normalization of generated colored noise from white noise
  • check execution of propagate-filter (compare sigma as float or np.ndarray)
  • review tests

Maximilian Gruber added 2 commits July 4, 2019 10:57
preparations for colored noise
588884e 
- method to generate correlation-matrix of correlated/colored noise
- method to generate colored noise from white noise (with same mean+var)
- added test for testsignal.py
- used propagate-filter-example to make test
- resolving issue #44
changed FIRuncFilter to accept correlated (colored) noise
e985255
@mgrub mgrub mentioned this pull request Jul 8, 2019
Closed
Maximilian Gruber added 2 commits July 8, 2019 15:06
working towards pull request
d9febcb 
- noise is proportional to 1/f^beta
- more and updated tests
- added user warning if color + beta are specified simultaneously
fixes for pytest
3b79b9d
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
compatibility numpy.flip()
e477ca9 
now compatible with 1.12<=numpy<1.16
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 8, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 9, 2019
@PTB-M4D PTB-M4D deleted a comment Jul 9, 2019
@mgrub mgrub mentioned this pull request Jul 10, 2019
Closed
@mgrub
Copy link
Contributor Author

mgrub commented Jul 10, 2019 •
edited
Loading

Next steps:

  • review new implementation with @eichstaedtPTB
  • if isinstance(sigma_noise, float) => maintain the more performant old implementations

@mgrub
Merge branch 'master' into handle_issue_#48
0e01025 
pulling latest changes from master into this issue-handling-branch (to
ease later pull request)
@codecov-io
Copy link

codecov-io commented Jul 11, 2019 •
edited
Loading

Codecov Report

Merging #55 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   35.88%   35.88%           
=======================================
  Files          18       18           
  Lines        1544     1544           
  Branches      263      263           
=======================================
  Hits          554      554           
  Misses        931      931           
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 448ece9...448ece9. Read the comment docs.

@PTB-M4D PTB-M4D deleted a comment Jul 11, 2019
mgrub
mgrub commented Nov 7, 2019
View reviewed changes
PyDynamic/misc/noise.py Outdated Show resolved Hide resolved
@PTB-M4D PTB-M4D deleted a comment Nov 8, 2019
@BjoernLudwigPTB
Copy link
Member

This would be the changelog as of now:

Fix

  • Set internal state of lfilter (23c9998)
  • Case: diag and no lowpass (586126f)
  • Case: corr and lowpass (4826892)
  • Case: diag and lowpass (e7269cc)
  • Return single sided acf (deae507)

Documentation

  • Add validation script for firuncfilter (448ece9)

@mgrub mgrub merged commit 7627790 into master Mar 20, 2020
@mgrub
Copy link
Contributor Author

mgrub commented Mar 20, 2020

@BjoernLudwigPTB : Please add the follwoing features to the changelog:
feat(FIRuncFilter): input signal of FIRuncFilter can have colored/correlated noise
feat(misc.noise): added utility functions in misc.noise for generation of colored noise and the corresponding right-sided autocorrelation

@BjoernLudwigPTB
Copy link
Member

@BjoernLudwigPTB : Please add the follwoing features to the changelog:
feat(FIRuncFilter): input signal of FIRuncFilter can have colored/correlated noise
feat(misc.noise): added utility functions in misc.noise for generation of colored noise and the corresponding right-sided autocorrelation

Check!

@BjoernLudwigPTB BjoernLudwigPTB mentioned this pull request Jun 16, 2020
Closed
@BjoernLudwigPTB BjoernLudwigPTB deleted the handle_issue_#48 branch September 18, 2021 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgrub @codecov-io @BjoernLudwigPTB