Check prev issue squashed #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2016 16:20
* Koha/Categories.pm: New file. * Koha/Category.pm: New file.
New feature: provide granular means to configure warnings about items
that have been issued to a particular borrower before, according to
their loan history.
- Global syspref ('CheckPrevIssue'), set to 'hardno' by default, allows
users to enable this feature library wide.
- Per patron category pref allows libraries to create overrides per
category, falling back on the global setting by default.
- Per patron pref allows switching the functionality on at the level
of patron. Fall-back to category settings by default.
* Koha/Patron/CheckPrevIssue.pm: New file
* C4/Circulation.pm (CanBookBeIssued): Introduce CheckPrevIssue check.
* admin/categories.pl: Pass along checkprevissue.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Expose
CheckPrevIssue per category setting.
* koha-tmpl/intranet-tmpl/prog/en/modules/preferences/patrons.pref:
Expose CheckPrevIssue syspref.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:
Expose per patron CheckPrevIssue preference.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Expose
per patron CheckPrevIssue preference.
* koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add
'CHECKPREVISSUE' confirmation message.
* installer/data/mysql/kohastructure.sql: Modify structure of
'categories', 'borrowers'.
* installer/data/mysql/sysprefs.sql: Add 'CheckPrevIssue'.
* installer/data/mysql/atomicupdate/checkPrevIssue.sql: New file.
* t/db_dependent/Patron/CheckPrevIssue.t: New file with unit tests.
Test plan:
- Apply patch.
- Run updatedatabase.
- Regenerate Koha Schema files.
- Run the unit tests.
- Verify 'CheckPrevIssue' is visible in Patrons sysprefs and can be
switched to 'hardyes', 'softyes', 'softno' and 'hardno'.
+ Check out previously issued items to a patron, checking the message
appears as expected.
- Verify no 'Check previous loans' setting appears on the borrower
category pages if the syspref is set to a 'hard' option.
- Verify 'Check previous loans' setting appears on the borrower
category pages and can be modified per borrower category.
+ Issue previously issued items to a borrower, checking the message
appears as expected (This setting should override the default
setting if that is set to a 'soft' option).
- Verify no 'Check previous loans' setting appears on the individual
borrower pages if the syspref is set to a 'hard' option.
- Verify 'Check previous loans' setting appears on individual borrower
pages and can be modified.
+ Issue previously issued items to a borrower, checking the message
appears as expected (This setting should override the category
setting and the default setting if the latter is set to a 'soft'
option).
| =head1 SYNOPSIS | ||
|
|
||
| Provide a feature to check whether a patron has previously checked out items | ||
| associated with a a biblio. |
|
Generally looks very good, well done.. Only had the one minor typo to spot :) |
|
In master now :) |
mrenvoize
pushed a commit
that referenced
this pull request
Nov 11, 2020
This commit implements the feedback from Katrin in comment #103 -> comment #108: - Fixed rebase issue mentioned in comment #103 - Fixed ILL notice display mentioned in comment #106 - Fixed bug with metadata display, though not the issue that was mentioned in comment #107 - Fixed buttons display mentioned in comment #107, in addition to some more buttons suffering the same issue Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.