Skip to content

Commit

Permalink
fixed broken permissions when deploying
Browse files Browse the repository at this point in the history
  • Loading branch information
fabiocicerchia committed Feb 28, 2022
1 parent e7813fb commit 728466a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions sys/cloudformation/parameters.prod.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[
{"ParameterKey": "ELBCertificateArn", "ParameterValue": ""},
{"ParameterKey": "EcrImageTagNginx", "ParameterValue": "1623402500"},
{"ParameterKey": "EcrImageTagPhp", "ParameterValue": "1623402500"},
{"ParameterKey": "EcrImageTagNginx", "ParameterValue": "1646054726"},
{"ParameterKey": "EcrImageTagPhp", "ParameterValue": "1646054726"},
{"ParameterKey": "Environment", "ParameterValue": "prod"},
{"ParameterKey": "ExecRoleArn", "ParameterValue": ""},
{"ParameterKey": "Subnets", "ParameterValue": ""},
Expand Down
3 changes: 2 additions & 1 deletion sys/docker/alpine-nginx/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ COPY --from=awsbuilder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-cert
COPY --from=awsbuilder /opt/aws/amazon-cloudwatch-agent /opt/aws/amazon-cloudwatch-agent

RUN mkdir -p /data/nginx/cache \
&& chmod -R 777 /data
&& chmod -R 777 /data \
&& chmod -R a+rX /application

This comment has been minimized.

Copy link
@drAlberT

drAlberT Feb 28, 2022

Contributor

Also nginx should run as www-data:www-data


ENTRYPOINT ["/application/sys/docker/alpine-nginx/start.sh"]

Expand Down
1 change: 1 addition & 0 deletions sys/docker/alpine-phpfpm/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ RUN /usr/local/bin/composer install --optimize-autoloader --no-ansi --no-interac

RUN mkdir -p /application/var/cache && chmod 777 /application/var/cache
RUN mkdir -p /application/var/log && chmod 777 /application/var/log
RUN chmod -R a+rX /application

This comment has been minimized.

Copy link
@drAlberT

drAlberT Feb 28, 2022

Contributor

PHP runs as www-data user, try to fix line 48 as follows instead:

COPY --chown=www-data:www-data . /application


ENTRYPOINT ["/application/sys/docker/alpine-phpfpm/start.sh"]

Expand Down

0 comments on commit 728466a

Please sign in to comment.