Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate routes to attributes #1194

Merged
merged 1 commit into from
May 5, 2024
Merged

migrate routes to attributes #1194

merged 1 commit into from
May 5, 2024

Conversation

garak
Copy link
Member

@garak garak commented Apr 26, 2024

(and add types to constants, and upgrade Sentry)

JellyBellyDev
JellyBellyDev approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@JellyBellyDev JellyBellyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

fabiocicerchia
fabiocicerchia approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@fabiocicerchia fabiocicerchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JellyBellyDev JellyBellyDev merged commit 1d50e5a into master May 5, 2024
5 checks passed
@JellyBellyDev JellyBellyDev deleted the attribute-routes branch May 5, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocicerchia fabiocicerchia fabiocicerchia approved these changes

@JellyBellyDev JellyBellyDev JellyBellyDev approved these changes

@AlessandroMinoccheri AlessandroMinoccheri Awaiting requested review from AlessandroMinoccheri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garak @fabiocicerchia @JellyBellyDev