Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response now is http-cached #40

Merged
merged 2 commits into from
Jun 5, 2013
Merged

Response now is http-cached #40

merged 2 commits into from
Jun 5, 2013

Conversation

agiuliano
Copy link
Member

No description provided.

@liuggio
Copy link
Member

liuggio commented Jun 4, 2013

Why only the shared... and what about max-age?

@agiuliano
Copy link
Member Author

because with the shared we can cache for every cache level instead of private.
max-age tells how long the cache is valid. For now, I suggest 1 hour, in the future we can adjust our aim according to the statistics provided by analytics

@liuggio
Copy link
Member

liuggio commented Jun 4, 2013

ehm but max-age is for private caching (browser for example) and shared is for proxy...

@agiuliano
Copy link
Member Author

Yes, indeed the property is smaxage and not maxage. As Cache class says smaxage =

     The number of seconds that the response is considered fresh by a public
     cache like a reverse proxy cache.

@leopro
Copy link
Member

leopro commented Jun 4, 2013

for me it's ok for merging

@liuggio
Copy link
Member

liuggio commented Jun 5, 2013

👍

liuggio added a commit that referenced this pull request Jun 5, 2013
Response now is http-cached
@liuggio liuggio merged commit 67eb88c into PUGX:master Jun 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants