Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings #599

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Fix build warnings #599

merged 1 commit into from
Aug 7, 2020

Conversation

mortenfyhn
Copy link
Contributor

I tried to build the avoidance repo just now, and the build failed
with clang. The error in clang is just a warning in gcc, so gcc builds,
but with warnings. I've taken the warnings reported by both clang and
gcc, and tried to fix them.

The issues were

  • assigning from an uninitialized variable,
  • reaching the end of a non-void function, and
  • passing a std::string to a "%s" specifier (expects char*).

I tried to build the avoidance repo just now, and the build failed
with clang. The error in clang is just a warning in gcc, so gcc builds,
but with warnings. I've taken the warnings reported by both clang and
gcc, and tried to fix them.

The issues were

* assigning from an uninitialized variable,
* reaching the end of a non-void function, and
* passing a std::string to a "%s" specifier (expects char*).
@jkflying jkflying merged commit 273eb7e into PX4:master Aug 7, 2020
@jkflying
Copy link
Contributor

jkflying commented Aug 7, 2020

Thanks! The global planner hasn't had much attention so I suspect there's a lot more of these kind of things...

@mortenfyhn mortenfyhn deleted the fix-build-warnings branch August 7, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants