WMS-315 | Table Filters #51
Conversation
|
@jouderianjr please review the new API introduced by ac44d98. I may be overdoing it, but it looks like this:
model =
checkBoxesEmpty
|> checkBox False
|> checkBox False
|> checkBox False
|> fromCheckBoxes
view cfg model =
toView Msg.ForBoxes labels model
|> renderElement cfg
labels =
labelsEmpty
|> label "Guaraná"
|> label "Coca-cola"
|> label "Fanta"(There is also radio behavior) Also, I don't now if I call it |
PedroHLC
force-pushed
the
wms-315-phase3-4
branch
from
ac44d98
to
1d7c8a5
Compare
There was a problem hiding this comment.
I think the dateFilter should work using Posix so maybe it should receive a function like (item -> Posix).
Also, unfortunately, elm-ui doesn't expose HTML5 date/time input fields, there is one open PR adding this: mdgriffith/elm-ui#231
If the guy does not fix his pr, I think I will create a new one, then we can use HTML5 date selector
|
@jouderianjr |
|
This is how it looks right now: |
|
Non API-related changes will continue in another PR... |
[TextField] Add withSize [Table] Cleanup [Checkbox] Add initial API [Table] Use extra-small TextField [Table] Add Select-Filter [Table] Add MultiText-Filter [Table] Add single date filter [Table] Detect (poorly) date validity on single date filter [Table] Date is a real type Cleanup (analyse) [Date] Add comparison [Table] Add range-date filter [Table] Add period-date filter [Showcase.Tables] Demo period-date filter [Primitives] Move TextField paddings back Apply jouderian's suggestions 1 Apply jouderian's suggestions 2 Update comment
| -- Internal | ||
|
|
||
|
|
||
| dateInput : msg -> (String -> msg) -> String -> String -> DateInput -> TextField msg |
There was a problem hiding this comment.
I'm wondering if makes sense to move this to the UI.Internal.DateInput module 🤔
There was a problem hiding this comment.
Yeah, with exception of withSize, withWIdth, withOnEnterPresed, I'll move it in #53
No description provided.