This repository has been archived by the owner on Jul 8, 2019. It is now read-only.
Remove hardCode value for node #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - seems sensible, will seek to merge once I promote the 1.1 RC to an official release and target 1.2 for the change to go live |
|
Sorry but this merge doesn't work for me, PathResolverImpl is not happy at all with "node" value as it can't get its absolute path. So the value for pathToNode in TsLintExecutorConfig is set to null. Then it fails in TsLintExecutorImpl.getBaseCommand as config.getPathToNode() is null. I had to set sonar.ts.tslint.nodePath property to my local node. I think that PathResolver.getPath should have "resolveAbsolutePath" parameter, calling getAbsolutePath or not. Regards |
|
Cool, shall investigate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need that because node isn't in environment path