Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments counter #32

Merged
merged 21 commits into from
Jun 29, 2023
Merged

Add comments counter #32

merged 21 commits into from
Jun 29, 2023

Conversation

NitBravoA92
Copy link
Collaborator

Hi @PabloBona 🀡

I've implemented some new functionality that I'd like you to review before I can integrate this code into the dev branch:

Updates Details πŸ“œ

βœ… I Create a comment Counter() function inside a new module. This function has encapsulated a code that is responsible for obtaining the number of comments that are listed in the Comments container and shows this count in the commentsCount container.

βœ… I call the commentsCounter() function when loading the comments modal and when a new comment is added so that the counter is kept up to date.

βœ… I update the HTML code of the nav section to activate some navigation links.

βœ… I update the HTML code of the footer section to activate the link of the logo and add links to the repositories of the authors of the web page.

If you feel there are bugs, major issues, or major changes that need to be made ♻️, please contact me πŸ“ž via Zoom or Slack call to discuss them.

@PabloBona
Copy link
Owner

Hey Carmen!

Thanks a lot for adding the new functionality. I'd be more than happy to review it for you. Here are my thoughts in a friendly and informal way:

Updates Details πŸ“œ

βœ… Awesome work on creating the comment Counter() function in a new module. This function takes care of counting the number of comments listed in the Comments container and displays the count in the commentsCount container. It's a smart move to keep things organized and reusable.

βœ… I really appreciate that you've made sure to call the commentsCounter() function both when the comments modal loads and when a new comment is added. This way, the comment counter stays up to date, giving users an accurate count. Great job on that!

βœ… It's cool to see that you've jazzed up the HTML code in the nav section to activate some navigation links. Keeping the navigation links fresh and functional adds to the overall user experience and makes it easy to move around the web page.

βœ… I also noticed that you've spruced up the HTML code in the footer section by activating the logo link and including links to the repositories of the authors. That's a nice touch, making it convenient for users to access those repositories and learn more about the authors' work.

@NitBravoA92 NitBravoA92 merged commit 5d51141 into dev Jun 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants