-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments counter #32
Conversation
β¦ve a new comment
β¦ renderCommentsList
β¦t form in the modal
Hey Carmen! Thanks a lot for adding the new functionality. I'd be more than happy to review it for you. Here are my thoughts in a friendly and informal way: Updates Details π β Awesome work on creating the comment Counter() function in a new module. This function takes care of counting the number of comments listed in the Comments container and displays the count in the commentsCount container. It's a smart move to keep things organized and reusable. β I really appreciate that you've made sure to call the commentsCounter() function both when the comments modal loads and when a new comment is added. This way, the comment counter stays up to date, giving users an accurate count. Great job on that! β It's cool to see that you've jazzed up the HTML code in the nav section to activate some navigation links. Keeping the navigation links fresh and functional adds to the overall user experience and makes it easy to move around the web page. β I also noticed that you've spruced up the HTML code in the footer section by activating the logo link and including links to the repositories of the authors. That's a nice touch, making it convenient for users to access those repositories and learn more about the authors' work. |
Hi @PabloBona π€΅
I've implemented some new functionality that I'd like you to review before I can integrate this code into the dev branch:
Updates Details π
β I Create a
comment Counter()
function inside a new module. This function has encapsulated a code that is responsible for obtaining the number of comments that are listed in the Comments container and shows this count in thecommentsCount
container.β I call the
commentsCounter()
function when loading the comments modal and when a new comment is added so that the counter is kept up to date.β I update the HTML code of the
nav
section to activate some navigation links.β I update the HTML code of the
footer
section to activate the link of the logo and add links to the repositories of the authors of the web page.If you feel there are bugs, major issues, or major changes that need to be made β»οΈ, please contact me π via Zoom or Slack call to discuss them.