Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for comments counter #33

Merged
merged 23 commits into from
Jun 29, 2023
Merged

Add tests for comments counter #33

merged 23 commits into from
Jun 29, 2023

Conversation

NitBravoA92
Copy link
Collaborator

Hi Partner @PabloBona 🀡

I have implemented the last functionality necessary to complete the project and I'd like you to review it before I can integrate this code into the dev branch:

Updates Details πŸ“œ

βœ… I have created a new test file called commentsCounter.test.js. In this file, I have created three test cases to check the quality and proper functioning of the commentsCounter() function, which displays the number of comments listed in the popup. These test cases are:

  • Test case 1: When there are no comments listed in the popup, the counter should be at zero (0). This test passed successfully.

  • Test case 2: When there are three comments listed in the popup, the number three (3) should appear in the counter. This test passed successfully.

  • Test case 3: When there are ten comments listed in the popup, the number ten (10) should appear in the counter. This test passed successfully.

If you feel there are bugs, major issues, or major changes that need to be made ♻️, please contact me πŸ“ž via Zoom or Slack call to discuss them.

@PabloBona
Copy link
Owner

Hi @NitBravoA92 ,

Congratulations! πŸŽ‰

I wanted to reach out and personally congratulate you on an outstanding job with the implementation of the test cases! Your contribution to this project has been truly remarkable. Not only have all the functionalities you created worked flawlessly, but your code is also exceptional.

I must say, the project looks absolutely amazing! πŸš€ There's really nothing left to do except... it's time to merge it! πŸ€–

Here are some highlights I'd like to mention:

βœ… The test case for checking the code quality of the showCounter function was exceptionally well done and it works perfectly. The test passed without any issues. I really appreciate that you applied the AAA pattern in Testing, which adds great value. Your test function is very well-structured, organized, and easy to understand. You've done an outstanding job. πŸš€πŸš€πŸš€

Once again, thank you for putting in a tremendous amount of effort to make this project exceptional. The functionalities you implemented have not only enhanced the overall appearance but have also ensured that the project works flawlessly according to the requirements! πŸ‘πŸ‘πŸ‘

Love our project looks!

@NitBravoA92 NitBravoA92 merged commit 527d2e3 into dev Jun 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants