Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for preselected rows #221

Closed
wants to merge 1 commit into from
Closed

Conversation

gururise
Copy link

This fix indexes preSelectedRow index correctly and thus fixes issue #207

Copy link

@minh-v minh-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@chrda81
Copy link

chrda81 commented Jul 20, 2023

Any news, when a new version is released with this fix?

@SubaruSpirit
Copy link

Is this fix in any of the releases? I'm currently using 0.3.4.post3, and pre_selected_rows is not working

jwood983 added a commit to jwood983/streamlit-aggrid that referenced this pull request Oct 13, 2023
Taking PRs PablocFonseca#204, PablocFonseca#221 and PablocFonseca#228 from original repo; Using 4 spaces for tab instead of 2 to make it far more readable
@gururise
Copy link
Author

Seems like this project may be dead. I've created a pypi package with this fix here:
https://pypi.org/project/streamlit-aggrid-bugfix/

@PablocFonseca PablocFonseca changed the base branch from main to dev February 15, 2024 13:31
PablocFonseca added a commit that referenced this pull request Feb 15, 2024
@hansthen
Copy link

Thanks for merging the fix. Any idea when a new version will be released to pypi?

@algorni
Copy link

algorni commented May 6, 2024

Is this fix in any of the releases? I'm currently using 0.3.4.post3, and pre_selected_rows is not working

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants