Fix GH-22 (TypeError with Streamlit 0.84) #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Streamlit 0.84, `component_value` is a `str` with JSON-encoded data, rather than a `dict` as with previous Streamlit versions. Added a check for `str` and if it's a `str`, we decode the JSON into a `dict`. Fixes: PablocFonsecaGH-22
|
This is a crucial fix for the latest streamlit 0.84. @PablocFonseca |
|
@PablocFonseca For me this PR is also critical in order to use streamlit-aggrid with the latest Streamlit Version 0.84. Which implements session states: https://blog.streamlit.io/session-state-for-streamlit/ Could be merged to main branch? For now, will fork the repo only to include this critical Pull Request :) Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Streamlit 0.84,
component_valueis astrwith JSON-encoded data, rather than adictas with previous Streamlit versions.Added a check for
strand if it's astr, we decode the JSON into adict.Fixes: GH-22