TASK: Split parsing logic from AST objects #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grebaldi
force-pushed
the
task/30/split-parsing-logic
branch
2 times, most recently
from
7aa7a59
to
8cc5fd4
Compare
grebaldi
force-pushed
the
task/27/remove-arithmetics
branch
from
cd7ef26
to
57b82e5
Compare
This also turns the EnumName class into a domain concern.
grebaldi
force-pushed
the
task/30/split-parsing-logic
branch
from
54a3d40
to
fb4b6c5
Compare
grebaldi
force-pushed
the
task/30/split-parsing-logic
branch
from
5efc19a
to
36cd9bb
Compare
9 tasks
mhsdesign
reviewed
Aug 10, 2023
Comment on lines
+271
to
+273
| $this->booleanLiteralParser ??= BooleanLiteralParser::singleton(); | ||
|
|
||
| $booleanLiteralNode = $this->booleanLiteralParser->parse($tokens); |
There was a problem hiding this comment.
I dont think, we need this second instance cache layer. Calling ::singleton() every-time should be fine?
Also it seems we are not using it for tests to swap out implementations...
There was a problem hiding this comment.
The underlying consideration is:
using($this->booleanLiteralParser) = cost_of(ReferenceLookup)
vs.
using(BooleanLiteralParser::singleton()) = cost_of(FunctionCall) + cost_of(ReferenceLookup)
It's just a performance optimization (maybe a bit over the top, but it's not nothing :D).
There was a problem hiding this comment.
As I'm working on #34, I noticed that I'm just one step away from being able to make all parsers static.
That will effectively eliminate this problem :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining TODOs