BUGFIX: Handle ArrayAccess in DataStructure validator gracefully

while the data structure validator accepted array acces it threw errors when an object actually used this because array_key_exists does not allow passing arrays.
PackageFactory · Jan 12, 2023 · 22b02f8 · 22b02f8
1 parent c42e26a
commit 22b02f8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/Classes/Validators/DataStructureValidator.php b/Classes/Validators/DataStructureValidator.php
@@ -37,11 +37,7 @@ protected function isValid($value)
             $result = $this->getResult() ?: new Result();
             foreach ($this->options['dataStructure'] as $key => $subValidator) {
                 if (is_array($value) || ($value instanceof \ArrayAccess)) {
-                    if (array_key_exists($key, $value)) {
-                        $subValue = $value[$key];
-                    } else {
-                        $subValue = null;
-                    }
+                    $subValue = $value[$key] ?? null;
                 } elseif (ObjectAccess::isPropertyGettable($value, $key)) {
                     $subValue = ObjectAccess::getPropertyPath($value, $key);
                 } else {

diff --git a/Classes/Validators/ShapeValidator.php b/Classes/Validators/ShapeValidator.php
@@ -37,11 +37,7 @@ protected function isValid($value)
             $result = $this->getResult() ?: new Result();
             foreach ($this->options['shape'] as $key => $subValidator) {
                 if (is_array($value) || ($value instanceof \ArrayAccess)) {
-                    if (array_key_exists($key, $value)) {
-                        $subValue = $value[$key];
-                    } else {
-                        $subValue = null;
-                    }
+                    $subValue = $value[$key] ?? null;
                 } elseif (ObjectAccess::isPropertyGettable($value, $key)) {
                     $subValue = ObjectAccess::getPropertyPath($value, $key);
                 } else {