Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Notify when installed database changed #555

Merged
merged 2 commits into from Jan 22, 2024

Conversation

mcrha
Copy link
Contributor

@mcrha mcrha commented Jun 16, 2022

Similar to the "updates-changed" signal emit "installed-changed" when
the backend notifies about changes in the installed apps, thus the library
user can update its UI accordingly. The signal only means it's possible
something changed, it doesn't mean there changed anything.

In case of the libdnf backend this may require rpm-software-management/libdnf#1542 on some systems.

@mcatanzaro
Copy link
Contributor

Ping reviewers

@mcrha
Copy link
Contributor Author

mcrha commented Feb 16, 2023

For what it's worth, the libdnf counter part is merged now (rpm-software-management/libdnf#1542).

@ximion ximion self-assigned this Nov 8, 2023
lib/packagekit-glib2/pk-control.c Outdated Show resolved Hide resolved
@ximion
Copy link
Collaborator

ximion commented Nov 18, 2023

This needs documentation and maybe should be added to the backend compatibility matrix as well (otherwise I think this is a useful feature).

@mcrha
Copy link
Contributor Author

mcrha commented Nov 20, 2023

This needs documentation

what kind of documentation do you mean, please?

maybe should be added to the backend compatibility matrix as well

Where is that, please? In the backends/dnf/README.md ?

@mcrha mcrha force-pushed the wip/installed-changed-signal branch from aa3b962 to f2b9e57 Compare November 20, 2023 13:02
@Conan-Kudo
Copy link
Member

@mcrha
Copy link
Contributor Author

mcrha commented Nov 20, 2023

Aha, I see. Thanks for the pointer.

@mcrha
Copy link
Contributor Author

mcrha commented Nov 20, 2023

I added a commit with the added entry in the pk-matrix.html (there are two backends calling pk_backend_installed_db_changed()), though the file mentions methods, not signals, thus it might be confusing in some way.

@mcrha mcrha force-pushed the wip/installed-changed-signal branch from 50d9f09 to 25073d3 Compare January 22, 2024 13:02
Similar to the "updates-changed" signal emit "installed-changed" when
the backend notifies about changes in the installed apps, thus the library
user can update its UI accordingly. The signal only means it's possible
something changed, it doesn't mean there changed anything.
@mcrha mcrha force-pushed the wip/installed-changed-signal branch from 25073d3 to 8da8f53 Compare January 22, 2024 13:03
@mcrha
Copy link
Contributor Author

mcrha commented Jan 22, 2024

I updated the branch:

  • applied Philip's suggestion
  • rebased to the latest main branch

docs/html/pk-matrix.html Show resolved Hide resolved
docs/html/pk-matrix.html Show resolved Hide resolved
@Conan-Kudo Conan-Kudo merged commit d8a4b4f into PackageKit:main Jan 22, 2024
3 checks passed
gnomesysadmins pushed a commit to GNOME/gnome-software that referenced this pull request Feb 21, 2024
PackageKit 1.2.9 adds a new "installed-changed" signal, which notifies
the listener about possible changes in the installed apps/packages, thus
listen on it and let the GUI know.

Depends on PackageKit/PackageKit#555

Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants