Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling up when we click on New filter #20

Closed
melalj opened this issue Jul 14, 2016 · 2 comments
Closed

Scrolling up when we click on New filter #20

melalj opened this issue Jul 14, 2016 · 2 comments
Assignees
@mrjones-plip

Comments

@melalj
Copy link
Member

melalj commented Jul 14, 2016

There's a little fix:

on https://github.com/Packet-Clearing-House/maptable/blob/master/src/components/Filters.js#L72

add() {

You'll need to prevent the default behavior of the <a href=#"> tag on click.

add(evt) {
    evt.preventDefault();
@mrjones-plip
Copy link
Contributor

it works! i'll do a PR

mrjones-plip pushed a commit that referenced this issue Jul 14, 2016
#20 fix browser scroll jump when adding filter
de6470b
@mrjones-plip mrjones-plip mentioned this issue Jul 14, 2016
Merged
@mrjones-plip
Copy link
Contributor

fixed with PR #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrjones-plip mrjones-plip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@melalj @mrjones-plip