Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative values break legend and map #27

Closed
mrjones-plip opened this issue Sep 15, 2016 · 0 comments
Closed

Negative values break legend and map #27

mrjones-plip opened this issue Sep 15, 2016 · 0 comments
Labels

Comments

@mrjones-plip
Copy link
Contributor

mrjones-plip commented Sep 15, 2016

Legend

If you are have a maptable with values that are negative, the legend break. Say our min value is -114 and max is 175. The legend is rendered correctly:

          -114 |---------------------------------------| 175

But when you roll over a country with a negative value, say -77, the legend indicator treats the smallest value as 0 instead of, in our case, -114, thus rendering the marker for the current country off of the legend:

          -114 |---------------------------------------| 175
^
-77

it should put it about here:

          -114 |---------------------------------------| 175
                         ^
                       -77

And, in case ASCII art isn't your thing, here's a screenshot ;)

broken legend

Map

Countries with a negative value always get a fill color of white. Instead, they should get the fill color of min

@mrjones-plip mrjones-plip changed the title Negative values break legend Negative values break legend and map Sep 15, 2016
mrjones-plip pushed a commit that referenced this issue Sep 15, 2016
.  Fix some bugs that should help, but not entirely fix, #27
mrjones-plip pushed a commit that referenced this issue Sep 20, 2016
custom colors for negative numbers #28 and fix #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant