Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive updates to window history #93

Closed
mrjones-plip opened this issue Nov 15, 2018 · 5 comments
Closed

Excessive updates to window history #93

mrjones-plip opened this issue Nov 15, 2018 · 5 comments
Labels

Comments

@mrjones-plip
Copy link
Contributor

mrjones-plip commented Nov 15, 2018

To reproduce:

Version 1 of bug:

  1. Open a new tab
  2. Go to http://example.com
  3. Go to https://packet-clearing-house.github.io/maptable/examples/minimal.html
  4. resize your window and zoom your browser
  5. Hold down your back button to view past pages you've visited

Expected: there are two items in my browser history: example.com & maptable example
Actual: there are dozens of maptable example and example.com is no where to be seen

Version 2 of bug

  1. Open a new tab
  2. Go to http://example.com
  3. Go to https://packet-clearing-house.github.io/maptable/examples/minimal.html
  4. resize your window and zoom your browser
  5. Click the back button

Expected: your browser goes back to example.com
Actual: your browser appears to do nothing

This is especially egregious when you have a maptable with no zoom or filters or table such that the user can only zoom their browser or resize their window. Suddenly the back button is "broken" because clicking it does nothing (but is actually taking them back one to one of the many window histories maptable has added)

@mrjones-plip
Copy link
Contributor Author

@melalj - if this is an easy fix (~1hr) please do it under the current contract - thanks!

melalj added a commit that referenced this issue Nov 15, 2018
@melalj
Copy link
Member

melalj commented Nov 15, 2018

It should be fixed with 5fa8111

@mrjones-plip
Copy link
Contributor Author

Awesome! I'll test and release 1.7.1 if it's good!

@mrjones-plip mrjones-plip reopened this Nov 15, 2018
@mrjones-plip
Copy link
Contributor Author

Oop! I didn't mean to close this with my first comment

@mrjones-plip
Copy link
Contributor Author

fix is good! 1.7.1 released! closing! thanks for the super speedy turn around ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants