Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in some corner cases this.legendCountry[attrKey] is not defined in GeoMap.js #96

Closed
mrjones-plip opened this issue Nov 15, 2018 · 0 comments
Closed

in some corner cases this.legendCountry[attrKey] is not defined in GeoMap.js #96

mrjones-plip opened this issue Nov 15, 2018 · 0 comments
Assignees
@mrjones-plip
Labels
bug

Comments

@mrjones-plip
Copy link
Contributor

we should check that {[this.legendCountry[attrKey]}} is defined in the {{if (typeof (attrValue) === 'object' && attrValue.legend)}} call
@mrjones-plip mrjones-plip self-assigned this Nov 15, 2018
mrjones-plip pushed a commit that referenced this issue Nov 15, 2018
per #95 and #96 change sort be desc first, and avoid undefined error
b3a48ae
mrjones-plip pushed a commit that referenced this issue Nov 15, 2018
Merge pull request #97 from Packet-Clearing-House/dev-95-96
924b9dd 
per #95 and #96 change sort be desc first, and avoid undefined error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrjones-plip mrjones-plip

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrjones-plip