Dev 88: New abstraction to aggregate date with the map + allow visualization refresh #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deprecated
rollupand now useaggregatein the definition of the attributes. See the updated documentation and new examples to understand how to implement it (Example: aggregate.html).I also allow to refresh the visualisation using
viz.render(), that is useful when we edit the aggregate function.The documentation has been improved a lot now, and the aggregate attribute opens new applications for MapTable.
The aggregate.scale = 'rank' replace the hack that was needed to color the country using their rank and percentile.
This work is the basis to fix the ticket #88 as it's an unusual behavior, and can be implemented outside of MapTable since we can now refresh the map.