Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

add popc op #1064

Merged
merged 1 commit into from Nov 23, 2022
Merged

add popc op #1064

merged 1 commit into from Nov 23, 2022

Conversation

FisherWY
Copy link
Contributor

#1115

Add popc op

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

thisjiang
thisjiang approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@thisjiang thisjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cinn/hlir/op/contrib/popc.cc Show resolved Hide resolved
thisjiang
thisjiang reviewed Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@thisjiang thisjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提醒下，我看commit用了多次push -f，建议能不用就不用。尽量用git commit -m "some description about this commit" + git push` 保证每一次修改都有迹可循，有描述。便于多次review的时候reviewer查看。

@thisjiang thisjiang merged commit 408255f into PaddlePaddle:develop Nov 23, 2022
@FisherWY
Copy link
Contributor Author

提醒下，我看commit用了多次push -f，建议能不用就不用。尽量用git commit -m "some description about this commit" + git push` 保证每一次修改都有迹可循，有描述。便于多次review的时候reviewer查看。

好的了解，以后会注意这一点的😊

@qlogcn qlogcn mentioned this pull request Dec 13, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thisjiang thisjiang thisjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FisherWY @CLAassistant @thisjiang