Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Add_SimpleCategorical #1169

Closed
wants to merge 15 commits into from
Closed

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jan 31, 2023

Add SimpleCategorical function
Function: Randomly sample an integer according to the given distribution.
param1(vector): candidates Candidate set of integers.
param2(vector): probs Probability distribution of candidate integer set.
Return Value(int): Random variables sampled.

@luotao1
Copy link
Collaborator

luotao1 commented Feb 7, 2023

还有 cinn-gpu-cudnn-off 流水线没过

@enkilee
Copy link
Contributor Author

enkilee commented Feb 13, 2023

@luotao1 Thanks. Already done.

Comment on lines +1707 to +1708
std::random_device seed;
std::default_random_engine engine(seed());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可参照SamplePerfectTile实现,在内部ScheduleImpl实现函数中新增参数传入随机数种子https://github.com/PaddlePaddle/CINN/blob/develop/cinn/ir/ir_schedule.cc#L2089

@@ -2921,5 +2921,23 @@ TEST(IrSchedule, GetChildBlocks) {
ASSERT_EQ(utils::GetStreamCnt(ir_sch.GetChildBlocks(root_block)), expected_expr);
}

TEST(IrSchedule, SimpleCategorical) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在schedule_desc.cc添加注册SimpleCategorical Step类型,并在schedule_desc_test.cc中补充对应单测,可参照其它原语实现

@luotao1
Copy link
Collaborator

luotao1 commented Feb 27, 2023

@enkilee 有空可以更新下 PR 哈

@enkilee
Copy link
Contributor Author

enkilee commented Feb 28, 2023

@enkilee 有空可以更新下 PR 哈

收到!集训回去就抓紧更新

@luotao1 luotao1 mentioned this pull request Mar 17, 2023
@CtfGo CtfGo closed this Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants