[Android] Update fastdeploy Android app ui module #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.Add photo recognition, real-time recognition, album selection recognition, detail page display and other functions.
|
|
DefTruth
changed the title
DefTruth
requested changes
Nov 7, 2022
| @@ -1,6 +1,6 @@ | |||
| <resources> | |||
| <!-- Default App name --> | |||
| <string name="app_name">FastDeploy PicoDet</string> | |||
| <string name="app_name">EasyEdge</string> | |||
| <!-- Other App name --> | |||
| <string name="detection_app_name">FastDeploy PicoDet</string> | |||
There was a problem hiding this comment.
这里的App相关的name都先改成EasyEdge
| @@ -1,6 +1,6 @@ | |||
| <resources> | |||
| <!-- Default App name --> | |||
| <string name="app_name">FastDeploy PicoDet</string> | |||
| <string name="app_name">EasyEdge</string> | |||
| <!-- Other App name --> | |||
| <string name="detection_app_name">FastDeploy PicoDet</string> | |||
| <string name="ocr_app_name">FastDeploy PP-OCRv2</string> | |||
| @@ -1,163 +1,14 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
这里是把camera也切换成新ui中的camera的吗？那原来的CameraSurfaceView是否还有必要保留？不需要的话就把原来的代码删除吧
| </LinearLayout> | ||
| </com.baidu.paddle.fastdeploy.app.ui.layout.ActionBarLayout> | ||
|
|
||
| <!-- 时实--> |
| @@ -46,8 +46,7 @@ public class SettingsActivity extends AppCompatPreferenceActivity implements | |||
| @Override | |||
| public void onCreate(Bundle savedInstanceState) { | |||
| super.onCreate(savedInstanceState); | |||
| // addPreferencesFromResource(R.xml.settings); | |||
| addPreferencesFromResource(R.xml.detection_settings); | |||
| addPreferencesFromResource(R.xml.settings); | |||
There was a problem hiding this comment.
这个detection的Preferences，应该从 detection_settings.xml 里读入，还是要分不同的场景 settings.xml是默认的，但是不同的examples是不同场景
| @@ -0,0 +1,42 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
layout里面的布局，都统一按照examples里面的场景来命名吧，比如:
default_result_page.xml # 默认
detection_result_page.xml # 目标检测
ocr_result_page.xml # OCR
classification_result_page.xml # 分类
....其他 layout命名按照同样的规范修改，比如：
result_table_popvivew.xml是用于detection的，就命名成 detection_result_table_popvivew.xml
DefTruth
changed the title
WinterGeng
force-pushed
the
gbd_android
branch
from
b84c249
to
09227b2
Compare
DefTruth
requested changes
Nov 8, 2022
|
|
||
| /** | ||
| * Created by ruanshimin on 2018/5/13. | ||
| */ |
There was a problem hiding this comment.
检查一下这些类似的注释，先不用保留，后面这些代码也可能修改
| @@ -1,6 +1,6 @@ | |||
| <resources> | |||
| <!-- Default App name --> | |||
| <string name="app_name">FastDeploy PicoDet</string> | |||
| <string name="app_name">EasyEdge</string> | |||
| <!-- Other App name --> | |||
| <string name="detection_app_name">FastDeploy PicoDet</string> | |||
WinterGeng
force-pushed
the
gbd_android
branch
from
2ce5593
to
8be52cd
Compare
WinterGeng
force-pushed
the
gbd_android
branch
from
8be52cd
to
277c86e
Compare
DefTruth
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Move EasyEdge Ui code to fastdeploy;
2.Add photo recognition, real-time recognition, album selection recognition, detail page display and other functions.