转换规则 No.208/220 #210
Merged
转换规则 No.208/220 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
reviewed
Jul 31, 2023
paconvert/api_mapping.json
Outdated
| "Matcher": "GenericMatcher", | ||
| "paddle_api": "paddle.linalg.cond", | ||
| "args_list": [ | ||
| "A", |
There was a problem hiding this comment.
这个参数顺序不是 torch.linalg.cond(A, p=None, *, out=None) 吗
There was a problem hiding this comment.
torch文档里写的是A，测试参数名称是input
https://github.com/pytorch/pytorch/blob/16df54239fecb97afbda30026931bbcac09542c4/aten/src/ATen/native/native_functions.yaml#L13603
torch代码没有使用Tensor A
There was a problem hiding this comment.
@co63oc 那这个args_list应该是 input、p、out 吧
There was a problem hiding this comment.
已修改，保留A是不确定torch不同版本是否不同
zhwesky2010
reviewed
Aug 3, 2023
| "torch.linalg.cond": { | ||
| "Matcher": "GenericMatcher", | ||
| "paddle_api": "paddle.linalg.cond", | ||
| "args_list": [ |
There was a problem hiding this comment.
那这个args_list应该是 input、p、out 吧
zhwesky2010
reviewed
Aug 3, 2023
tests/test_linalg_cond.py
Outdated
| import torch | ||
| x = torch.tensor([[1., 0, -1], [0, 1, 0], [1, 0, 1]]) | ||
| out = torch.tensor([]) | ||
| result = torch.linalg.cond(x, p=float('inf'), out=out) |
There was a problem hiding this comment.
补充一下这些case，最新的单测规范，这个如果都 不指定关键字，args_list写错了应该就会触发问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
#112
208 torch.linalg.cond https://github.com/PaddlePaddle/docs/blob/develop/docs/guides/model_convert/convert_from_pytorch/api_difference/linalg/torch.linalg.cond.md
测试时torch参数名称input，增加input参数项映射
220 torch.nn.init.calculate_gain https://github.com/PaddlePaddle/docs/blob/develop/docs/guides/model_convert/convert_from_pytorch/api_difference/init/torch.nn.init.calculate_gain.md
PR APIs