Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

转换规则 No.334 #212

Merged
merged 1 commit into from
Aug 3, 2023
Merged

转换规则 No.334 #212

merged 1 commit into from
Aug 3, 2023

Conversation

co63oc
Copy link
Collaborator

@co63oc co63oc commented Jul 30, 2023

PR Docs

#112

334 torch.special.round

torch.special.round 是 torch.round别名,测试支持decimals 参数,文档中没有说明

已有文档 https://github.com/PaddlePaddle/docs/blob/96d13d280b5a77d0716ccb48541425ffa1a81ac9/docs/guides/model_convert/convert_from_pytorch/api_difference/others/torch.special.round.md#L4

PR APIs

334 torch.special.round

@paddle-bot
Copy link

paddle-bot bot commented Jul 30, 2023

Thanks for your contribution!

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 30, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 31, 2023
"Matcher": "RoundMatcher",
"args_list": [
"input",
"decimals",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意:转换规则 需要与 映射关系文档 保持同步,彼此互相验证,互相校正

如果已有映射文档,就在PR描述里写上:已有文档且检查无误
如果没有映射文档,就需要先编写与转换规则思路一致的文档

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改文档 PR PaddlePaddle/docs#6080

@zhwesky2010
Copy link
Collaborator

zhwesky2010 commented Jul 31, 2023

PR Docs

#112

334 torch.special.round

torch.special.round 是 torch.round别名,测试支持decimals 参数,文档中没有说明

已有文档 https://github.com/PaddlePaddle/docs/blob/96d13d280b5a77d0716ccb48541425ffa1a81ac9/docs/guides/model_convert/convert_from_pytorch/api_difference/others/torch.special.round.md#L4

PR APIs

334 torch.special.round

映射文档也需要修一下,torch的API文档有时也有一些bug,后面发现了都可以修

@co63oc
Copy link
Collaborator Author

co63oc commented Aug 1, 2023

文档也需要修一下,torch的API文档有时也有一些bug,后面发现了都可以修

已修改

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 6c1cde7 into PaddlePaddle:master Aug 3, 2023
8 checks passed
@co63oc co63oc deleted the api334 branch August 4, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR status: proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants