Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

转换规则 No.228/229 #248

Merged
merged 2 commits into from
Aug 28, 2023
Merged

转换规则 No.228/229 #248

merged 2 commits into from
Aug 28, 2023

Conversation

co63oc
Copy link
Collaborator

@co63oc co63oc commented Aug 24, 2023

PR Docs

#112

228 torch.sparse.addmm
229 torch.sparse.mm

文档参数不一致修改 PaddlePaddle/docs#6126

PR APIs

torch.sparse.addmm
torch.sparse.mm

zhwesky2010
zhwesky2010 previously approved these changes Aug 25, 2023
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010
Copy link
Collaborator

@co63oc 这几个单测case运行失败了还需要看下

@co63oc
Copy link
Collaborator Author

co63oc commented Aug 25, 2023

@co63oc 这几个单测case运行失败了还需要看下

CPU环境不支持,已修改

@zhwesky2010
Copy link
Collaborator

@co63oc 这几个单测case运行失败了还需要看下

CPU环境不支持,已修改

对的,paddle目前只支持了sparse matmul GPU版本的kernel

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个本地GPU版本的paddle能运行通过吧,可以截一个运行通过的截图

@co63oc
Copy link
Collaborator Author

co63oc commented Aug 28, 2023

torch.sparse.addmm 运行
图片

torch.sparse.mm 运行
图片

@co63oc co63oc merged commit 7c8b5d6 into PaddlePaddle:master Aug 28, 2023
8 checks passed
@co63oc co63oc deleted the api230 branch August 30, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants