Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arm] add conv_5x5s2_dw to support any padding #2770

Merged
merged 82 commits into from
Jan 16, 2020

Conversation

chenjiaoAngel
Copy link
Collaborator

conv_5x5s2_dw
pooling1xx1s2p0_max

….cc to distinguish between conv3x3s1_depthwise_fp32.cc
it is coped from __gemm_sdot_meta_.h
fix build error in kernels/x86/conv_compute.h
Merge branch 'develop' of git://github.com/PaddlePaddle/Paddle-Lite into PaddlePaddle-develop
Merge branch 'conv_pad' of https://github.com/chenjiaoAngel/Paddle-Lite into conv_pad
delete con2d_transpose test, this test can found in test/math/
Merge branch 'conv_pad' of https://github.com/chenjiaoAngel/Paddle-Lite into conv_pad
Merge branch 'develop' of git://github.com/PaddlePaddle/Paddle-Lite into conv_pad
kernel/arm/test_pool_compute
Copy link
Collaborator

@yiicy yiicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remain issue will be fix in next pr

dr2 = dr1 + w_in;
dr3 = dr2 + w_in;
//! process bottom pad
if (j + 3 > h_in) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j + 3 -> j + 4下同

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是一次输出2行,需要输入4行,j+3;一次输出4行结果,需要输入6行,j+5

break;
}
}
if (h * 2 + 4 >= hin) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h 的判断不应该 + 4

@yiicy yiicy merged commit c35d8e1 into PaddlePaddle:develop Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants