[X86] refactor elementwise OP for X86; remove _mm256_zeroupper() beca… #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use of incorrect result;
|
Thanks for your contribution! |
zhupengyang
approved these changes
Sep 18, 2021
| @@ -38,7 +38,7 @@ static void activate_relu_inplace(float *data, int len, float alpha, int mode) { | |||
| __m256 vec_data = _mm256_loadu_ps(data + i); | |||
| _mm256_storeu_ps(data + i, _mm256_max_ps(vec_data, vec_zero)); | |||
| } | |||
| _mm256_zeroupper(); | |||
| // _mm256_zeroupper(); | |||
| @@ -294,11 +294,12 @@ class RoiAlignComputeTester : public arena::TestCase { | |||
| uint64_t new_end = *rois_lod0.rbegin() + bno + 1; | |||
| rois_lod0.push_back(new_end); | |||
| for (int i = 0; i < (bno + 1); ++i) { | |||
| float x1 = randint(0, width / spatial_scale_ - pooled_width_); | |||
| float y1 = randint(0, height / spatial_scale_ - pooled_height_); | |||
| float x1 = 1.f * randint(0, width / spatial_scale_ - pooled_width_); | |||
| } | ||
| } | ||
|
|
||
| #endif // LITE_WITH_ARM |
| const typename Config::T* diny, | ||
| typename Config::T* dout, | ||
| int num) { | ||
| static_assert((IS_X_SINGLE && IS_Y_SINGLE) != true, |
There was a problem hiding this comment.
Suggested change
| static_assert((IS_X_SINGLE && IS_Y_SINGLE) != true, | |
| static_assert(!(IS_X_SINGLE && IS_Y_SINGLE), |
Comment on lines
+153
to
+170
| // marco func add | ||
| ElementWiseFunc(Add) ElementWiseFuncBCast(Add) | ||
| // marco func sub | ||
| ElementWiseFunc(Sub) ElementWiseFuncBCast(Sub) | ||
| // marco func mul | ||
| ElementWiseFunc(Mul) ElementWiseFuncBCast(Mul) | ||
| // marco func max | ||
| ElementWiseFunc(Max) ElementWiseFuncBCast(Max) | ||
| // marco func min | ||
| ElementWiseFunc(Min) ElementWiseFuncBCast(Min) | ||
| // marco func div | ||
| ElementWiseFunc(Div) ElementWiseFuncBCast(Div) | ||
| // marco func floordiv | ||
| ElementWiseFunc(FloorDiv) ElementWiseFuncBCast(FloorDiv) | ||
| // marco func mod | ||
| ElementWiseFunc(Mod) ElementWiseFuncBCast(Mod) | ||
| // marco func pow | ||
| ElementWiseFunc(Pow) ElementWiseFuncBCast(Pow) |
Comment on lines
+51
to
+56
| #define ElementWiseFuncBCast(op) \ | ||
| template <typename T> \ | ||
| void Elementwise_Broadcast_##op(const T* dinx, \ | ||
| const T* diny, \ | ||
| T* dout, \ | ||
| int batch, \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[X86] refactor elementwise OP for X86;
remove _mm256_zeroupper();