[ARM]fix ios bug && add mul quant op && add quant transformer support #7310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
xingjing1
changed the title
…into fix_ios_bug_develop
xingjing1
force-pushed
the
fix_ios_bug_develop
branch
from
ab5d385
to
f2fa9a2
Compare
…into fix_ios_bug_develop
| @@ -61,6 +61,27 @@ namespace arm { | |||
| din_batch, weights, chout, hout, wout, kh, kw, paddings[0], paddings[1], \ | |||
| paddings[2], paddings[3], dilations[0], dilations[1], dout_batch, &ctx | |||
|
|
|||
| template <> | |||
| void Conv2DTransposeCompute<PRECISION(kFloat), | |||
There was a problem hiding this comment.
这个删除，已在公用ReInitWhenNeeded() 添加实现，请见conv_transpose_compute.h
|
|
||
| virtual void ReInitWhenNeeded() { |
lite/kernels/arm/matmul_compute.cc
Outdated
| for (int i = 0; i < n_; i++) { | ||
| param.output_scale = param.input_scale * param.weight_scale[i]; | ||
| if (param.weight_scale.size() == 1) { |
There was a problem hiding this comment.
这个是不是就要这样改写：
if (param.weight_scale.size() == 1) {
param.output_scale =
param.input_scale * param.weight_scale[0] * param.alpha;
for (int i = 0; i < n_; i++) {
scale_[i] = param.output_scale;
}
} else {
for (int i = 0; i < n_; i++) {
param.output_scale = param.input_scale * param.weight_scale[i];
scale_[i] = param.output_scale;
}
}
| } | ||
|
|
||
| template <> | ||
| void MulCompute<PRECISION(kInt8), PRECISION(kFloat)>::PrepareForRun() { |
There was a problem hiding this comment.
下次补上 <int8, int8> 这个case
| @@ -77,7 +77,7 @@ TEST(mul_arm, retrive_op) { | |||
| } | |||
|
|
|||
| TEST(mul_arm, init) { | |||
| MulCompute mul; | |||
| MulCompute<PRECISION(kFloat), PRECISION(kFloat)> mul; | |||
There was a problem hiding this comment.
顺便一起补上，mul OP int8 的单测case
| scale_.resize(n_); | ||
| scale_one.resize(m_); | ||
| for (int i = 0; i < n_; i++) { | ||
| param.output_scale = param.input_scale * param.weight_scale[i]; |
There was a problem hiding this comment.
这个地方不用判断 param.weight_scale size大小吗？我记得上一版有判断，如果size 是1，一直是常数；否则是这个
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.