Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metal] fix_split #7466

Merged
merged 2 commits into from
Nov 3, 2021
Merged

[Metal] fix_split #7466

merged 2 commits into from
Nov 3, 2021

Conversation

xiaoxiaohehe001
Copy link
Collaborator

@xiaoxiaohehe001 xiaoxiaohehe001 commented Oct 26, 2021

【Metal】合并split 宏定义 重写split

@xiaoxiaohehe001 xiaoxiaohehe001 changed the title [Paddle-Lite] fix_split [Paddle-Lite Metal] fix_split Oct 26, 2021
@paddle-bot-old
Copy link

Thanks for your contribution!

zhangjun
zhangjun previously approved these changes Oct 28, 2021
@@ -1,4 +1,4 @@
/* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.
/* Copyright (c) 2021 ftypeaddleftypeaddle Authors. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里修改一下

Comment on lines 136 to 139
r[0] = 0;
r[1] = 0;
r[2] = 0;
r[3] = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftype4 r = 0,可以写简洁点

Comment on lines 159 to 162
r[0] = 0;
r[1] = 0;
r[2] = 0;
r[3] = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@zhangjun zhangjun self-requested a review October 28, 2021 11:07
@zhangjun zhangjun changed the title [Paddle-Lite Metal] fix_split [Metal] fix_split Oct 28, 2021
Copy link
Collaborator

@zhangjun zhangjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangjun zhangjun merged commit 3451cc1 into PaddlePaddle:develop Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants