Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OP][Host][OpUTPy] Add unfold operator and host implementation #8305

Merged
merged 5 commits into from
Jan 22, 2022

Conversation

shentanyue
Copy link
Collaborator

No description provided.

@paddle-bot-old
Copy link

Thanks for your contribution!

lite/kernels/host/unfold_compute.cc Outdated Show resolved Hide resolved
lite/kernels/host/unfold_compute.cc Outdated Show resolved Hide resolved
lite/operators/unfold_op.cc Outdated Show resolved Hide resolved
}
}

inline int CalcOutputSize(int input_size,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否考虑后面去掉类似的重复实现的代码?下个 PR修改一下吧

Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

关于代码风格和冗余的实现,后面再提个 PR 改下

CHECK_GT(output_width, 0);
int output_col_length = output_height * output_width;
output_shape.push_back(output_col_length);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多余的空行后面记得删除掉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@hong19860320 hong19860320 merged commit 1276460 into PaddlePaddle:develop Jan 22, 2022
@shentanyue shentanyue deleted the add_host_unfold_op branch January 24, 2022 02:43
WeiLi233 pushed a commit to WeiLi233/Paddle-Lite that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants