Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenCL][Pass][Kernel]support Y not persistable for matmul #8701

Merged

Conversation

zhenlin-work
Copy link
Collaborator

@zhenlin-work zhenlin-work commented Mar 22, 2022

主要支持:

  1. 同时注册两个相同名字的OpenCL kernel,但其中一个输入tensor绑定的target不同。修改kernel picking pass中的kernel打分逻辑,对应opt转出模型同时支持的单线输入和双线输入两种case的kernel选择。
  2. 添加Y persistable=false情况下的cl_kernel实现。
  3. 修改python单测使之能够同时支持两种kernel的测试。

@zhenlin-work zhenlin-work force-pushed the support_unpersistable_matmul branch 3 times, most recently from b78a1a8 to 0357cbd Compare March 22, 2022 17:19
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Mar 22, 2022
@PaddlePaddle PaddlePaddle unlocked this conversation Mar 22, 2022
@zhenlin-work zhenlin-work force-pushed the support_unpersistable_matmul branch 2 times, most recently from 63ee897 to f90ed38 Compare March 23, 2022 03:21
zhaoyang-star
zhaoyang-star previously approved these changes Mar 23, 2022
Copy link
Collaborator

@zhaoyang-star zhaoyang-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@weishengying weishengying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@zhenlin-work zhenlin-work merged commit c765c3a into PaddlePaddle:develop Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants