[XPU]. Fixed the mode error in pad3d. #9506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbn03
requested review from
zhupengyang,
hong19860320 and
liyancas
as code owners
|
Thanks for your contribution! |
wangleilei001
suggested changes
Sep 27, 2022
| padding[2] = pads[2]; | ||
| padding[3] = pads[3]; | ||
| padding[4] = pads[0]; | ||
| padding[5] = pads[1]; |
lite/kernels/xpu/pad3d_compute.cc
Outdated
| in_dims[4], | ||
| in_dims[1], | ||
| in_dims[2], | ||
| in_dims[3], |
There was a problem hiding this comment.
建议使用前面的 n c d h w这些变量作为参数 ---- 理论上不应该存在is_ncdhw为两种值时调用两次api
wbn03
force-pushed
the
pad3d
branch
2 times, most recently
from
b30e2ea
to
d2aebe8
Compare
|
LGTM |
zealoct
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复了xpu上pad3d算子所有模式都使用constant的错误。