Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard pre-commit hooks #2289

Closed
wangkuiyi opened this issue May 26, 2017 · 2 comments
Closed

Use standard pre-commit hooks #2289

wangkuiyi opened this issue May 26, 2017 · 2 comments
Assignees

Comments

@wangkuiyi
Copy link
Collaborator

wangkuiyi commented May 26, 2017

In /.pre-commit-config.yaml, we refer to
repo: https://github.com/reyoung/mirrors-yapf.git, which is a fork of https://github.com/pre-commit/mirrors-yapf. The difference is and is only changing the version of yapf from 0.11.3 to 0.13.2, as shown here.

screen shot 2017-05-26 at 10 51 47 am

Is this versioning critical? If not, how about we just use the upstream https://github.com/pre-commit/mirrors-yapf? If it is critical, how about we create a fork under PaddlePaddle?

@wangkuiyi wangkuiyi assigned reyoung and emailweixu and unassigned reyoung May 26, 2017
@wangkuiyi
Copy link
Collaborator Author

I noticed this issue because when I was trying to fix the pre-commit error of #2288, I had to use the upstream hooks repo; otherwise, I wouldn't be able to reformat the Python code.

reyoung added a commit to reyoung/Paddle that referenced this issue May 31, 2017
* use PaddlePaddle org to manage mirrors-yapf
* Fix PaddlePaddle#2289
@wangkuiyi
Copy link
Collaborator Author

@reyoung told that the version of yapf is critical. So we forked pre-commit's standard hooks to organization PaddlePaddle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants