Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU version of crossMapNormalBwd is not implemented #294

Closed
luotao1 opened this issue Oct 31, 2016 · 3 comments
Closed

CPU version of crossMapNormalBwd is not implemented #294

luotao1 opened this issue Oct 31, 2016 · 3 comments
Assignees

Comments

@luotao1
Copy link
Contributor

luotao1 commented Oct 31, 2016

The CPU version of crossMapNormalBwd is already implemented by @hedaoyuan . Thus, when this function can be merged here?

@backyes
Copy link
Contributor

backyes commented Oct 31, 2016

@luotao1, just add more detailed background descriptions on this issue to follow the suggestions from #283

@luotao1
Copy link
Contributor Author

luotao1 commented Oct 31, 2016

crossMapNormalBwd is used in CMRProjectionNormLayer::backward. However, its CPU version is not implemented.

void CpuMatrix::crossMapNormalBwd(Matrix& localGrad, Matrix& denoms,
                                  Matrix& preOutV, Matrix& localOutV,
                                  size_t channels, size_t imgSizeH,
                                  size_t imgSizeW, size_t size, float scale,
                                  float pow) {
  LOG(FATAL) << "Not implemented";

  CHECK(imgSizeH * imgSizeW * channels == preOutV.getWidth());
  CHECK(denoms.getHeight() == preOutV.getHeight() &&
        denoms.getWidth() == preOutV.getWidth() &&
        preOutV.getHeight() == height_ && preOutV.getWidth() == width_);
  CHECK(denoms.getHeight() == localGrad.getHeight() &&
        denoms.getWidth() == localGrad.getWidth());

  // NOLINT // TODO:
}

@hedaoyuan
Copy link
Contributor

OK, I will submit pr, and add to the 0.8.2 version.

@luotao1 luotao1 added this to the 0.8.2 milestone Nov 1, 2016
This was referenced Dec 13, 2016
DesmonDay pushed a commit to DesmonDay/Paddle that referenced this issue May 29, 2023
Co-authored-by: yangjunchao <yangjunchao@baidu.com>
danleifeng pushed a commit to danleifeng/Paddle that referenced this issue Sep 13, 2023
Co-authored-by: yangjunchao <yangjunchao@baidu.com>
lizexu123 pushed a commit to lizexu123/Paddle that referenced this issue Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants