Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate oneDNN operators to under PHI #45308

Closed
yaomichael opened this issue Aug 22, 2022 · 5 comments
Closed

Migrate oneDNN operators to under PHI #45308

yaomichael opened this issue Aug 22, 2022 · 5 comments
Assignees
Labels

Comments

@yaomichael
Copy link

需求描述 Feature Description

design doc: https://github.com/PaddlePaddle/docs/blob/develop/docs/design/phi/design_en.md

with Op name (op_type) as the unit, MKLDNN currently has a total of 100 OpKernels, which we divide into three categories:

  1. Migrate first: a total of 53 (42 to be migrated, 11 have been migrated by YuanRisheng). The parameters required by this type of Kernel are consistent with the CPU&GPU Kernel. Currently, the migration is non-blocking. In order to verify the mechanism, we have migrated 11 of them;
  2. Migrate later: 23 in total. This kind of Kernel has the problem of Extra parameters in OpMaker that we mentioned before. It requires more parameters than CPU&GPU Kernel, so this part of Kernel is recommended to be migrated after we complete the extra parameter cleaning. The specific time will be tell you later (expectedly in mid to late September);
  3. No need to migrate: 24 in total. This type of Kernel mainly includes two types of operators, one is the historical operators that have been abandoned, such as reshape, flatten, etc, these abandoned operators will be gradually removed from the framework, so they will no need to be migrated; the other is framework function related operators. For example, related to fusion or quantize, such operators may not be migrated to PHI in the future, and may continue to be maintained in the main framework.

替代实现 Alternatives

No response

@paddle-bot
Copy link

paddle-bot bot commented Aug 22, 2022

您好,我们已经收到了您的问题,会安排技术人员尽快解答您的问题,请耐心等待。请您再次检查是否提供了清晰的问题描述、复现代码、环境&版本、报错信息等。同时,您也可以通过查看官网API文档常见问题历史IssueAI社区来寻求解答。祝您生活愉快~

Hi! We've received your issue and please be patient to get responded. We will arrange technicians to answer your questions as soon as possible. Please make sure that you have posted enough message to demo your request. You may also check out the APIFAQGithub Issue and AI community to get the answer.Have a nice day!

@yaomichael yaomichael assigned jczaja and unassigned minghaoBD Aug 22, 2022
@yaomichael
Copy link
Author

@jczaja jczaja added the Intel label Aug 22, 2022
@paddle-bot paddle-bot bot added status/following-up 跟进中 and removed status/new-issue 新建 labels Aug 23, 2022
@Silv3S
Copy link
Member

Silv3S commented Sep 2, 2022

Merged


Cherry-picks to release/2.4 branch

@chenwhql
Copy link
Contributor

@Silv3S @piotrekobi Our kernel migration work will be released in Paddle v2.4, and the release/2.4 branch bas been created at 9.9, so the PRs merged into develop after 9.9 need to be cherry-pick to release/2.4, remind attention it, thanks.

https://github.com/PaddlePaddle/Paddle/tree/release/2.4

@Silv3S
Copy link
Member

Silv3S commented Sep 26, 2022

Part II

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants