[PHI] transpose2_grad op migration #46139

paulinagacek · 2022-09-16T09:46:55Z

PR types

Others

PR changes

Others

Describe

migrate transpose2_grad operator to phi

paddle-bot · 2022-09-16T09:46:58Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

CLAassistant · 2022-09-16T09:46:59Z

All committers have signed the CLA.

… transpose2_grad_op_migration

…linaGacek/Paddle into transpose2_grad_op_migration

paulinagacek · 2022-09-20T10:23:19Z

@piotrekobi can you review please?

piotrekobi

Please make some changes for clarity and style:

Remove phi::funcs i phi:: wherever possible (everywhere apart from the kernel registration at the end). In phi namespace leave only funcs::
Move the transpose_grad_kernel.h import to the top with a new line in between the other imports (like in https://github.com/PaddlePaddle/Paddle/pull/46051/files)
Change the kernel file name to transpose2_grad_kernel.cc

… transpose2_grad_op_migration

piotrekobi

LGTM

piotrekobi · 2022-09-23T13:59:05Z

@chenwhql Please review

YuanRisheng · 2022-09-26T03:03:32Z

paddle/phi/kernels/onednn/transpose2_grad_kernel.cc

+
+}  // namespace phi
+
+PD_REGISTER_KERNEL(


The transpose2 in Fluid is renamed to transpose in PHI. So , the registered name should be transpose_grad and this file should be renamed transpose_grad_kernel.cc. On the other hand, CI-coverage is not successful, maybe the reason is that the registerd name is wrong.

… transpose2_grad_op_migration

paulinagacek · 2022-09-29T14:49:41Z

@chenwhql @YuanRisheng PR-CI-Windows tests give weird results, can you please take a look at it?

chenwhql · 2022-09-30T06:49:37Z

paddle/phi/kernels/onednn/transpose_grad_kernel.cc

+  std::vector<int> reversed_axis(axis);
+  int ndims = axis.size();
+  if (ndims == 1) {
+    Copy(dev_ctx, out_grad, out_grad.place(), false, x_grad);


I found that phi::Copy and framework::TensorCopy behave inconsistently in the mkldnn scenario, you can still use framework::TensorCopy for the time being, the problem of phi::Copy I will solve

chenwhql · 2022-09-30T06:51:48Z

@paulinagacek the problem of PR-CI-Windows may be caused by the Copy difference

… transpose2_grad_op_migration

paulinagacek · 2022-10-08T14:42:40Z

paddle/phi/backends/onednn/onednn_reuse.h

@@ -1076,9 +1076,7 @@ class TransposeOneDNNHandler {
  std::shared_ptr<dnnl::memory> AcquireDstMemory(DenseTensor* output,
                                                 Place place) {
    auto dst_md = Axis2MemoryDesc(dims_, axis_);
-    output->Resize(make_ddim(dims_));


I deleted Resize() and now it seems to work properly, @chenwhql @YuanRisheng please review

done, please take a look at the Coverage CI @paulinagacek

I have checked the Coverage CI in my machine and the code is exercised. I have marked it as successful.

* op migrated, Copy(OneDNNContext, ...) added * mutable_data & op registration in fluid removed * refactoring * OneDNNGetDataType to uppercase * missing cpu check added, handler moved to .h file * name changed to transpose_grad * Copy changed back to TensorCopy * Resizing corrected, Copy(OneDNNContext) removed

* Revert pool+grad oneDNN kernel conversion (#45989) * [PHI] transpose2_grad op migration (#46139) * op migrated, Copy(OneDNNContext, ...) added * mutable_data & op registration in fluid removed * refactoring * OneDNNGetDataType to uppercase * missing cpu check added, handler moved to .h file * name changed to transpose_grad * Copy changed back to TensorCopy * Resizing corrected, Copy(OneDNNContext) removed Co-authored-by: Piotr Paturej <48731682+piotrekobi@users.noreply.github.com> Co-authored-by: Paulina Gacek <paulina.gacek@intel.com>

paddle-bot bot added contributor External developers status: proposed labels Sep 16, 2022

paulinagacek added 2 commits September 16, 2022 11:45

op migrated, Copy(OneDNNContext, ...) added

ebd80bf

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

490e6dc

… transpose2_grad_op_migration

Silv3S added the Intel label Sep 19, 2022

paddle-bot bot removed the status: proposed label Sep 19, 2022

Silv3S mentioned this pull request Sep 19, 2022

Migrate oneDNN operators to under PHI #45308

Closed

paulinagacek added 3 commits September 19, 2022 09:20

mutable_data & op registration in fluid removed

addde63

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

35ec9b7

… transpose2_grad_op_migration

Merge branch 'transpose2_grad_op_migration' of https://github.com/Pau…

28ffdb7

…linaGacek/Paddle into transpose2_grad_op_migration

paulinagacek marked this pull request as ready for review September 19, 2022 16:53

piotrekobi suggested changes Sep 20, 2022

View reviewed changes

paulinagacek added 8 commits September 20, 2022 13:16

refactoring

78f8af6

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

8501e7f

… transpose2_grad_op_migration

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

fbe2c5d

… transpose2_grad_op_migration

OneDNNGetDataType to uppercase

bd49216

missing cpu check added, handler moved to .h file

fa1369b

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

d2603a1

… transpose2_grad_op_migration

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

2cbe8f4

… transpose2_grad_op_migration

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

d566a95

… transpose2_grad_op_migration

piotrekobi self-requested a review September 22, 2022 10:43

piotrekobi previously approved these changes Sep 22, 2022

View reviewed changes

piotrekobi requested a review from chenwhql September 22, 2022 10:44

YuanRisheng reviewed Sep 26, 2022

View reviewed changes

paulinagacek dismissed piotrekobi’s stale review via 6d8de58 September 27, 2022 14:00

name changed to transpose_grad

d33d261

paulinagacek added 4 commits September 27, 2022 15:59

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

6d8de58

… transpose2_grad_op_migration

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

372b367

… transpose2_grad_op_migration

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

cf4eaf0

… transpose2_grad_op_migration

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

131bdc3

… transpose2_grad_op_migration

chenwhql reviewed Sep 30, 2022

View reviewed changes

paulinagacek added 4 commits September 30, 2022 11:46

Copy changed back to TensorCopy

6a344c8

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

e70eb82

… transpose2_grad_op_migration

Resizing corrected, Copy(OneDNNContext) removed

9470a6c

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

14881c2

… transpose2_grad_op_migration

paulinagacek commented Oct 8, 2022

View reviewed changes

YuanRisheng approved these changes Oct 9, 2022

View reviewed changes

chenwhql approved these changes Oct 10, 2022

View reviewed changes

YuanRisheng merged commit e3407a8 into PaddlePaddle:develop Oct 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PHI] transpose2_grad op migration #46139

[PHI] transpose2_grad op migration #46139

paulinagacek commented Sep 16, 2022

paddle-bot bot commented Sep 16, 2022

CLAassistant commented Sep 16, 2022 •

edited

paulinagacek commented Sep 20, 2022

piotrekobi left a comment

piotrekobi left a comment

piotrekobi commented Sep 23, 2022

YuanRisheng Sep 26, 2022 •

edited

paulinagacek commented Sep 29, 2022

chenwhql Sep 30, 2022

chenwhql commented Sep 30, 2022

paulinagacek Oct 8, 2022

chenwhql Oct 10, 2022

YuanRisheng Oct 10, 2022

[PHI] transpose2_grad op migration #46139

[PHI] transpose2_grad op migration #46139

Conversation

paulinagacek commented Sep 16, 2022

PR types

PR changes

Describe

paddle-bot bot commented Sep 16, 2022

CLAassistant commented Sep 16, 2022 • edited

paulinagacek commented Sep 20, 2022

piotrekobi left a comment

Choose a reason for hiding this comment

piotrekobi left a comment

Choose a reason for hiding this comment

piotrekobi commented Sep 23, 2022

YuanRisheng Sep 26, 2022 • edited

Choose a reason for hiding this comment

paulinagacek commented Sep 29, 2022

chenwhql Sep 30, 2022

Choose a reason for hiding this comment

chenwhql commented Sep 30, 2022

paulinagacek Oct 8, 2022

Choose a reason for hiding this comment

chenwhql Oct 10, 2022

Choose a reason for hiding this comment

YuanRisheng Oct 10, 2022

Choose a reason for hiding this comment

CLAassistant commented Sep 16, 2022 •

edited

YuanRisheng Sep 26, 2022 •

edited