Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

编译单测时的warning #746

Closed
luotao1 opened this issue Dec 6, 2016 · 1 comment
Closed

编译单测时的warning #746

luotao1 opened this issue Dec 6, 2016 · 1 comment
Assignees

Comments

@luotao1
Copy link
Contributor

luotao1 commented Dec 6, 2016

编译单测的时候,会出现大量Flags.h和Matrix.h的warning,类似如下:

/home/luotao/Paddle/paddle/utils/Flags.h(28): warning: using-declaration ignored -- it refers to the current namespace

/home/luotao/Paddle/paddle/utils/Flags.h(29): warning: using-declaration ignored -- it refers to the current namespace

/home/luotao/Paddle/paddle/utils/Flags.h(32): warning: using-declaration ignored -- it refers to the current namespace

/home/luotao/Paddle/paddle/utils/Flags.h(33): warning: using-declaration ignored -- it refers to the current namespace

/home/luotao/Paddle/paddle/utils/Flags.h(41): warning: using-declaration ignored -- it refers to the current namespace

/home/luotao/Paddle/paddle/utils/Flags.h(43): warning: using-declaration ignored -- it refers to the current namespace

/home/luotao/Paddle/paddle/math/Matrix.h(1162): warning: overloaded virtual function "paddle::Matrix::addBias" is only partially overridden in class "paddle::GpuMatrix"

/home/luotao/Paddle/paddle/math/Matrix.h(1162): warning: overloaded virtual function "paddle::Matrix::collectBias" is only partially overridden in class "paddle::GpuMatrix"

/home/luotao/Paddle/paddle/math/Matrix.h(1538): warning: overloaded virtual function "paddle::Matrix::addBias" is only partially overridden in class "paddle::CpuMatrix"

/home/luotao/Paddle/paddle/math/Matrix.h(1538): warning: overloaded virtual function "paddle::Matrix::collectBias" is only partially overridden in class "paddle::CpuMatrix"

其中,Flags.h的warning都是在P_DECLARE_string(XXX)时出现的。

@wangkuiyi
Copy link
Collaborator

wangkuiyi commented Dec 13, 2016

@luotao1 @reyoung We are going to fix #721. In this work, we will have to remove all global variables, particularly, global flags definitions. In this work, we will remove our own flag definition logic, and use gflags literally instead.

This was referenced Dec 13, 2016
wangxicoding pushed a commit to wangxicoding/Paddle that referenced this issue Dec 9, 2021
yaozhixin pushed a commit to graphcore/Paddle-fork that referenced this issue May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants