Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kernel to Beam Search OP #10052

Merged
merged 15 commits into from
Apr 28, 2018
Merged

Conversation

ktlichkid
Copy link

resolve #10026

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2018

CLA assistant check
All committers have signed the CLA.

@ktlichkid ktlichkid force-pushed the fix-10026 branch 2 times, most recently from e36f2ec to 8abbb3d Compare April 20, 2018 08:39
@ktlichkid ktlichkid force-pushed the fix-10026 branch 3 times, most recently from 8f30c50 to 64509fd Compare April 24, 2018 12:20
ktlichkid added 3 commits April 25, 2018 04:00
Merge remote-tracking branch 'upstream/develop' into fix-10026
Merge branch 'fix-10026' of github.com:ktlichkid/Paddle into fix-10026
@ktlichkid ktlichkid changed the title [WIP] Trying to add kernel to Beam Search OP Added kernel to Beam Search OP Apr 27, 2018
Superjomn
Superjomn previously approved these changes Apr 27, 2018
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

auto scores_var = scope.FindVar(Input("scores"));
auto pre_ids_var = scope.FindVar(Input("pre_ids"));
void Compute(const framework::ExecutionContext& context) const override {
auto ids_var = context.Input<framework::LoDTensor>("ids");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto => auto*

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ktlichkid ktlichkid merged commit c93a624 into PaddlePaddle:develop Apr 28, 2018
@ktlichkid ktlichkid deleted the fix-10026 branch April 28, 2018 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beam_search_op cannot run on GPU
4 participants