Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VariableResponse support deserialize var into local scope #10060

Merged
merged 2 commits into from
Apr 20, 2018
Merged

VariableResponse support deserialize var into local scope #10060

merged 2 commits into from
Apr 20, 2018

Conversation

jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Apr 19, 2018 •
edited

fix: #10061
task: #9941

@jacquesqiao jacquesqiao mentioned this pull request Apr 19, 2018
Closed
13 tasks
typhoonzero
typhoonzero previously approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@typhoonzero
Copy link
Contributor

Fix #10056 waiting CI.

typhoonzero
typhoonzero approved these changes Apr 20, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@jacquesqiao jacquesqiao merged commit ba927b8 into PaddlePaddle:develop Apr 20, 2018
@jacquesqiao
Copy link
Member Author

@typhoonzero Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

@Yancey1989 Yancey1989 Awaiting requested review from Yancey1989

Assignees
No one assigned
Labels
None yet
Projects
fluid support async training
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VariableResponse support deserialize var into local scope
2 participants
@jacquesqiao @typhoonzero