Refine listen and serve op #10080
Merged
Refine listen and serve op #10080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
changed the title
jacquesqiao
changed the title
13 tasks
typhoonzero
reviewed
Apr 20, 2018
| sleep(5); | ||
| // Write to a file of server selected port for python use. | ||
| SavePort(rpc_service_); | ||
| RunSyncUpdate(&executor, program, &recv_scope, prefetch_block); |
There was a problem hiding this comment.
Can you please rename RunSyncUpdate to RunSyncLoop, for:
- server side program may not always be "updates" and,
- this function is an event loop.
typhoonzero
approved these changes
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate RunSyncLoop to a method, prepare for RunAsyncLoop.
tasks: #9941