Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split optimization ops on pserver to independenty blocks #10123

Merged
merged 5 commits into from
Apr 23, 2018
Merged

split optimization ops on pserver to independenty blocks #10123

merged 5 commits into from
Apr 23, 2018

Conversation

jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Apr 22, 2018 •
edited

tasks: #9941

typhoonzero
typhoonzero reviewed Apr 22, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix this, the issue is introduced by #10027

python/paddle/fluid/distribute_transpiler.py Outdated

# append global ops
opt_state_block = None
if global_ops:
opt_state_block = pserver_program.create_block(per_opt_block.idx)
for glb_op in global_ops:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can move inside if statement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

python/paddle/fluid/distribute_transpiler.py Outdated

# append op to the current block
per_opt_block = append_block
per_opt_block = None
pre_block_idx = GLOBAL_BLOCK_IDX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No globals is needed here, just record the latest block id.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

typhoonzero
typhoonzero reviewed Apr 22, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one comment

python/paddle/fluid/distribute_transpiler.py Outdated
@@ -25,6 +25,8 @@
LOOKUP_TABLE_GRAD_TYPE = "lookup_table_grad"
RPC_CLIENT_VAR_NAME = "RPC_CLIENT_VAR"

GLOBAL_BLOCK_IDX = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

typhoonzero
typhoonzero previously approved these changes Apr 22, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, can remove that line later.

@typhoonzero typhoonzero merged commit dd7a48b into PaddlePaddle:develop Apr 23, 2018
@jacquesqiao jacquesqiao mentioned this pull request Apr 23, 2018
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

@Yancey1989 Yancey1989 Awaiting requested review from Yancey1989

Assignees
No one assigned
Labels
None yet
Projects
fluid support async training
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacquesqiao @typhoonzero