Expose ROI Pooling into Python API. #10169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dyning
commented
Apr 24, 2018
•
dyning
commented
- Expose ROI Pooling into Python API.
- Add unit testing.
|
duyuning seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Please sign the CLA and make CI passed first. |
qingqing01
reviewed
Apr 24, 2018
| """ | ||
| helper = LayerHelper('roi_pool', **locals()) | ||
| dtype = helper.input_dtype() | ||
| pool_out = helper.create_tmp_variable(dtype) |
There was a problem hiding this comment.
Also need to create variable for Argmax.
| @@ -359,6 +359,17 @@ def test_topk(self): | |||
| self.assertIsNotNone(indices) | |||
| print(str(program)) | |||
|
|
|||
| def test_roi_pool(self): | |||
| print("test_roi_pool") | |||
| @@ -3759,3 +3760,44 @@ def label_smooth(label, | |||
| outputs={"Out": smooth_label}, | |||
| attrs={"epsilon": float(epsilon)}) | |||
| return smooth_label | |||
|
|
|||
|
|
|||
| def roi_pool(input, rois, pooled_height=1, pooled_width=1, spatial_scale=1.0): | |||
There was a problem hiding this comment.
Please also add roi_pool in doc : https://github.com/PaddlePaddle/Paddle/blob/develop/doc/fluid/api/layers.rst#nn
| "pooled_width": pooled_width, | ||
| "spatial_scale": spatial_scale | ||
| }) | ||
| return pool_out, argmaxes |
There was a problem hiding this comment.
一般ROI pool 之后的op需要argmaxes么？如果不需要，就不用return了吧。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.