Modified iou_similarity_op cuda kernel #10224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baiyfbupt
commented
Apr 26, 2018
•
baiyfbupt
commented
| Time unit: ms | Event | Total | Min. | Max. | Ave. |
|---|---|---|---|---|---|
| Before | thread0::iou_similarity | 10 | 6.77757 | 0.64416 | 0.677757 |
| Optimized | thread0::iou_similarity | 10 | 0.064512 | 0.085952 | 0.072 |
|
root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
qingqing01
reviewed
Apr 26, 2018
|
|
||
| inline HOSTDEVICE void operator()(size_t tid) const { | ||
| size_t row_id = tid/cols_; | ||
| size_t col_id = tid%cols_; |
There was a problem hiding this comment.
Please note the code format and install pre-commit and cpplint.
size_t row_id = tid / cols_;
size_t col_id = tid % cols_;|
|
||
| platform::ForRange<DeviceContext> for_range( | ||
| static_cast<const DeviceContext&>(ctx.device_context()), x_n); | ||
| for_range(functor); | ||
| static_cast<const DeviceContext&>(ctx.device_context()), x_n*y_n); |
There was a problem hiding this comment.
Please note the code format x_n * y_n.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.